Enhance Database Modeling and SQLAlchemy Compatibility#1593
Closed
cubxxw wants to merge 1 commit intofastapi:masterfrom
Closed
Enhance Database Modeling and SQLAlchemy Compatibility#1593cubxxw wants to merge 1 commit intofastapi:masterfrom
cubxxw wants to merge 1 commit intofastapi:masterfrom
Conversation
YuriiMotov
reviewed
Sep 3, 2025
Member
YuriiMotov
left a comment
YuriiMotov
left a comment
There was a problem hiding this comment.
@cubxxw, thanks for your interest and efforts!
I think we don't need any of these changes
| class UserBase(SQLModel): | ||
| email: EmailStr = Field(unique=True, index=True, max_length=255) | ||
| email: EmailStr = Field( | ||
| unique=True, index=True, max_length=255, sa_type=String(255) |
Member
There was a problem hiding this comment.
In current version of SQLModel, setting max_length will already create correct column type email VARCHAR(255)
|
|
||
| class UserRegister(SQLModel): | ||
| email: EmailStr = Field(max_length=255) | ||
| email: str = Field(max_length=255) |
Member
There was a problem hiding this comment.
I don't see a point in this change. Moreover, it will allow creating users with invalid emails
Comment on lines
+88
to
+95
| # Remove foreign_key constraint, but keep it indexed for performance | ||
| owner_id: uuid.UUID = Field(index=True, nullable=False) | ||
| owner: User | None = Relationship( | ||
| back_populates="items", | ||
| sa_relationship_kwargs={ | ||
| "primaryjoin": "User.id == Item.owner_id", | ||
| "foreign_keys": "[Item.owner_id]", | ||
| }, |
Member
There was a problem hiding this comment.
What kind of performance boost will this give?
I think we don't need it
Member
|
Yep, I think we don't currently need this, so I'll pass on this for now, but thanks for the interest! ☕ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several changes to the
backend/app/models.pyfile to enhance database modeling and improve compatibility with SQLAlchemy. The key updates include adjustments to field definitions, changes to relationships, and the removal of certain constraints.Changes to field definitions:
emailfield inUserBaseto explicitly usesa_type=String(255)for better SQLAlchemy compatibility.emailfield type inUserRegister,UserUpdate, andUserUpdateMefromEmailStrtostrfor consistency and to avoid type-related issues.Changes to relationships:
itemsrelationship in theUsermodel to includesa_relationship_kwargsfor defining cascading behavior and specifying join conditions.owner_idfield in theItemmodel to remove theforeign_keyconstraint while keeping it indexed for performance. Addedsa_relationship_kwargsto theownerrelationship for explicit join conditions.